search

kubernetes-sigs / krew-index

Plugin index for https://github.com/kubernetes-sigs/krew. This repo is for plugin maintainers.
https://krew.sigs.k8s.io
Apache License 2.0
635 stars 487 forks source link

Auto-accept version bumps for plugins #233

Closed ahmetb closed 3 years ago

ahmetb commented 5 years ago

Currently, most PRs in krew-index require no manual review as they just bump the version of a plugin.

We need a bot to look at the PRs, note that only url/sha256/version fields are changed and:

In the long run, we can automatically create a batch PR to bump up the plugin versions by looking at repositories the plugins are coming from and their available releases (once a day or so), but that can come later.

If I can find some free time, I'm planning to:

  1. use github webhooks to detect created and synchronized push events
  2. use patch link of the PR to understand the patch.
  3. using https://godoc.org/github.com/sourcegraph/go-diff/diff or something simpler, look at the patch, and see if it is exactly doing a trivial version bump.
  4. if so, approve by commenting /lgtm /approve from my account, or we can create a bot account.

The code doesn't have to live in krew, this may live on a personal repo and can be deployed to something like Cloud Run to handle github webhook invocations.

/kind proposal

ahmetb commented 5 years ago

Heads-up @corneliusweig I'm enabling auto bump checks on this repo. It might be annoying, in that case ping me and I'll close.

ahmetb commented 5 years ago

The source code I used can be found at https://github.com/ahmetb/krew-index-autoapprove .

corneliusweig commented 4 years ago

I think the auto-approver has proven it's usefulness and stability quite well.

@ahmetb Are you still planning to use a different Github account for this? Otherwise, I think you can close this.

ahmetb commented 4 years ago

Lets keep this open maybe we can add the tool here as a cmd somehow.

ahmetb commented 4 years ago

/hold

papuneftali commented 3 years ago

Duplicate of #

ahmetb commented 3 years ago

Duplicate of #

@papuneftali you are warned, again.

ahmetb commented 3 years ago

OK it seems like this is working pretty well now. Time to call it resolved. /close /hold cancel

k8s-ci-robot commented 3 years ago

@ahmetb: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/krew-index/issues/233#issuecomment-833054022): >OK it seems like this is working pretty well now. >Time to call it resolved. >/close >/hold cancel Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.