kubernetes-sigs / krew-index

Plugin index for https://github.com/kubernetes-sigs/krew. This repo is for plugin maintainers.
https://krew.sigs.k8s.io
Apache License 2.0
635 stars 487 forks source link

Add kubectl-terminate to krew-index #511

Closed ishantanu closed 4 years ago

ishantanu commented 4 years ago

Hi 👋

Opening this issue to explore the possibility of adding kubectl-terminate to the krew-index and distributing it via krew.

CC @corneliusweig @xcoulon

corneliusweig commented 4 years ago

Thanks @ishantanu for bringing this up!


That plugin looks really good. I've never had such an issue but I imagine how painful it can be if it comes up. So I'd love to see it added. @xcoulon what do you think? Would you care to submit a manifest for it? The guide to write a manifest is here: https://github.com/kubernetes-sigs/krew/blob/master/docs/DEVELOPER_GUIDE.md

ahmetb commented 4 years ago

Something that removes finalizers, FINALLY! 😄

xcoulon commented 4 years ago

Thanks @ishantanu for bringing this up!

That plugin looks really good. I've never had such an issue but I imagine how painful it can be if it comes up. So I'd love to see it added. @xcoulon what do you think? Would you care to submit a manifest for it? The guide to write a manifest is here: https://github.com/kubernetes-sigs/krew/blob/master/docs/DEVELOPER_GUIDE.md

hello @corneliusweig ! Sorry for the late response, I was AFK last week. Sure, I also thought about submitting this plugin but @ishantanu was faster than me ;) I'll take a look at the guide to write the manifest.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

ahmetb commented 4 years ago

pinging if you're still interested @xcoulon.

xcoulon commented 4 years ago

ah yes, sorry, it slipped my mind. Thanks for the reminder, I'll try to give it a look soon!

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

xcoulon commented 4 years ago

I still haven't had time to take a look at it, sorry 😬

fejta-bot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 4 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/krew-index/issues/511#issuecomment-667670954): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ytsarev commented 3 years ago

any chance it will get into the index? It is very useful plugin

xcoulon commented 3 years ago

any chance it will get into the index? It is very useful plugin

hello @ytsarev ! thanks for the reminder and sorry for not taking care of this request earlier, I've been pretty busy but I will try to address it soon.

xcoulon commented 3 years ago

@ytsarev it's been a long overdue but here is finally the PR to add the terminate plugin to Krew: https://github.com/kubernetes-sigs/krew-index/pull/1606 😅

ytsarev commented 3 years ago

@xcoulon amazing, thanks! :)