search

kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.42k stars 369 forks source link

feat: make go install faster #725

Closed georgettica closed 3 years ago

georgettica commented 3 years ago

I installed krew using 

go install -x sigs.k8s.io/krew/cmd/krew@latest

(the x shows the progress)

and it took a very long time to build and install.. would that be a good way of installing krew?

( I like it because I can point the GOBIN to wherever I want, and anyways this is the way binaries are installed in newer go versions)

ahmetb commented 3 years ago

It's not a supported method of installation because krew can't update itself that way or register itself as a plugin. It will work but you're on your own that way.

Also I am not sure why optimizing the one-time install cost is important. It's likely pulling down other dependencies.

/close

k8s-ci-robot commented 3 years ago

@ahmetb: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/krew/issues/725#issuecomment-945156100): >It's not a supported method of installation because krew can't update itself that way or register itself as a plugin. It will work but you're on your own that way. > >Also I am not sure why optimizing the one-time install cost is important. It's likely pulling down other dependencies. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
georgettica commented 3 years ago

Well, you can use it to krew install krew

But I am totally ok with this decision of not using this installation

Maybe at some point the community will want this installation method