search

kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.42k stars 369 forks source link

Add ppc64le support #755

Closed mgiessing closed 2 years ago

mgiessing commented 2 years ago

Fixes #... Related issue: #...

Added support for ppc64le architecture and therefore not really a feature content-wise

k8s-ci-robot commented 2 years ago

Welcome @mgiessing!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

prb112 commented 2 years ago

HI All, I'm a ppc64le user and would like to follow along on this work. Is there a thread to follow/discussion on updates?

mgiessing commented 2 years ago

@soltysh can you approve or tell me what needs to be changed in order to merge?

ahmetb commented 2 years ago

Sorry, I forgot to review this one. I don't know much about ppc architecture. Can you please explain how it is used on developer/operator machines where kubectl plugins would be installed? I'm trying to distinguish if it is more of a server architecture than it is for dev machines.

prb112 commented 2 years ago

@ahmetb the ppc64le architecture is used as a foundation for OpenShift nodes. The kubectl is used mainly by the operators to manage the environment from either a jump server/bastion server.

I hope this helps. @mgiessing may have more to add/or a different view point.

mgiessing commented 2 years ago

You've brought it to the point! Besides OpenShift, ppc64le can of course also be used as the foundation for "vanilla" Kubernetes. As indicated by @prb112 kubectl is in this context mainly used by the operators of such a cluster. Since Power has a strong focus on Linux & open source this commit was part of the upstreaming work in kubespray to enable ppc64le along many of its components (e.g. krew).

ahmetb commented 2 years ago

Thanks for the explanation.

The kubectl is used mainly by the operators to manage the environment from either a jump server/bastion server.

Do you think people actually install kubectl plugins (i.e. convenience tools) to the bastion/jump servers? Nearly none of the kubectl plugins are not thoroughly vetted from a security perspective and I am hoping people don't run plugins from their bastion servers.

This has no extra cost to us, but I'd love to really understand which plugins you'll install with this. Today, none of the plugins distribute for ppc64le and I believe the only submission we ever got was from Red Hat, so I'm trying to ensure there's actually >1 users who need this.

prb112 commented 2 years ago

Hi @ahmetb yes - I think it'll be installed more frequently and in more cases. Thank you for asking. Thanks, Paul

prb112 commented 2 years ago

Hi @ahmetb here is an example I hit today. I went to install the minio operator, and it requires the krew plugin before I can install it.

Many thanks, and I hope this helps further this PR

Paul

ahmetb commented 2 years ago

Thanks, yeah we should probably add. Also keep in mind that minio operator probably doesn't offer a binary for this platform because up until now, we didn't distribute krew for it. So those plugins have to update their manifests here in krew-index.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mkumatag commented 2 years ago

/remove-lifecycle stale

mkumatag commented 2 years ago

Thanks, yeah we should probably add. Also keep in mind that minio operator probably doesn't offer a binary for this platform because up until now, we didn't distribute krew for it. So those plugins have to update their manifests here in krew-index.

@ahmetb wondering if we can merge this PR if no further comments?

ahmetb commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, mgiessing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/krew/blob/master/OWNERS)~~ [ahmetb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 2 years ago

@ahmetb any idea when this will get into the release?