search

kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.39k stars 370 forks source link

Bump up to Go 1.18 #778

Closed JohnTitor closed 1 year ago

JohnTitor commented 2 years ago

Is there a policy about bumping up Go version? If not, I'm happy to do it.

ahmetb commented 2 years ago

Should be OK.

JohnTitor commented 2 years ago

Okay, I investigated this and found some blockers. The first is some lints in golangci-lint don't support Go 1.18. In our case, structcheck and unparam don't. I think this should be fine as our codebase isn't changed so frequently. The second is, to get golangci-lint's Go 1.18 support, we have to bump up it to 1.45.0 or higher. This itself isn't a problem but https://github.com/daixiang0/gci/issues/54 is. It reports some false positives, see https://github.com/JohnTitor/krew/runs/6422270074?check_suite_focus=true for example. I checked golangci config and I found we also use goimports. I think it's enough to format/order imports and could remove gci. Is there a reason to have gci here?

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

JohnTitor commented 2 years ago

Still needs an update from golangci-lint,

/remove-lifecycle stale

JohnTitor commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

JohnTitor commented 2 years ago

Superseded by #801 Well, I thought this is a PR, sorry!

JohnTitor commented 2 years ago

https://github.com/kubernetes-sigs/krew/pull/801 will resolve this but not yet. /remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ahmetb commented 1 year ago

/close

k8s-ci-robot commented 1 year ago

@ahmetb: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/krew/issues/778#issuecomment-1427378005): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.