kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.39k stars 370 forks source link

Support Kerberos/Negotiate authentication for corporate proxies #788

Closed vpinna80 closed 1 year ago

vpinna80 commented 2 years ago

It seems that krew cannot be used behind a corporate proxy that requires Negotiate authentication.

W0620 11:37:48.731292 7510 install.go:164] failed to install plugin "krew": install failed: failed to unpack into staging dir: failed to unpack the plugin archive: failed to obtain plugin archive: failed to download "https://github.com/kubernetes-sigs/krew/releases/download/v0.4.3/krew-linux_amd64.tar.gz": Get "https://github.com/kubernetes-sigs/krew/releases/download/v0.4.3/krew-linux_amd64.tar.gz": Proxy authentication required

ahmetb commented 2 years ago

I am not sure if there's a clean way of solving this (like setting the HTTPS_PROXY env variable). I think any solution will involve bringing Kerberos dependency to this repo.

If there's a way to add this without complicating the codebase for a small amount of users, I am interested in making it work.

Looking at how other open source tools handle this and bringing ideas from there can help here.

vpinna80 commented 2 years ago

Usually other tools delegate to curl for natively supporting Kerberos authentication. This time I managed with including credentials in HTTPx_PROXY.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ahmetb commented 2 years ago

I suspect we'll skip supporting Kerberos/Negotiate authentication mostly because it has never come up, until this particular issue. I'm afraid delegating to curl won't work very well either, as we support Windows as well, and curl would be a net-new dependency and may break some people's workflows.

If we get more evidence that there's a broad need for this, we can work on implementing it with a library like gokrb5.

ahmetb commented 2 years ago

/retitle Support Kerberos/Negotiate authentication for corporate proxies

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/krew/issues/788#issuecomment-1321324271): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.