search

kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.42k stars 369 forks source link

detect download failures when status code > 200 #820

Closed daniel-garcia closed 1 year ago

daniel-garcia commented 1 year ago

detect download failures when status code is > 200

819

k8s-ci-robot commented 1 year ago

Welcome @daniel-garcia!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

stmcginnis commented 1 year ago

/lgtm

ahmetb commented 1 year ago

Thanks for this patch, sorry it didn't catch my attention earlier. Can we also add a test case (with a httptest server responding with 404 ) to validate this doesn't regress?

daniel-garcia commented 1 year ago

Thanks for this patch, sorry it didn't catch my attention earlier. Can we also add a test case (with a httptest server responding with 404 ) to validate this doesn't regress?

done.

stmcginnis commented 1 year ago

/lgtm

ankishagarwal commented 1 year ago

Can we complete this if all okay ? We need this change, thank you

ahmetb commented 1 year ago

/lgtm

thanks.

ahmetb commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ankishagarwal, daniel-garcia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/krew/blob/master/OWNERS)~~ [ahmetb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ahmetb commented 1 year ago

/retest