search

kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.42k stars 369 forks source link

Allow installing without sha256 when using --manifest-url #846

Closed grosser closed 6 months ago

grosser commented 11 months ago

I want to distribute my plugin to a few colleagues at first before getting it into krew-index. For that I want them to be able to just install from my manifest url which will point to the latest archive on github. Atm this breaks because I always have to add a sha, so I have to tag a release and then come back and get the sha and re-push the manifest.

I'd love either have:

Option A: no sha manifest, allow me toset sha256: false or sha256: 'insecure' to opt-out Option B: No-sha install option: a --no-sha or --ignore-sha or --insecure flag that others can use to have a simple 1-line installer without me having to keep the sha up to date.

ahmetb commented 11 months ago

-manifest-url/-manifest-file is largely intended for testing manifests; not for distribution. You can still ship an executable to your colleagues and they can put it on their PATH?

We could change the scope and behavior here but I suspect it won't be a major UX improvement for a broad audience.

grosser commented 11 months ago

If it's intended for testing then allowing not using a Sha would make that even easier ?

On Tue, Dec 26, 2023, 6:11 PM Ahmet Alp Balkan @.***> wrote:

-manifest-url/-manifest-file is largely intended for testing manifests; not for distribution. You can still ship an executable to your colleagues and they can put it on their PATH?

We could change the scope and behavior here but I suspect it won't be a major UX improvement for a broad audience.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/krew/issues/846#issuecomment-1869881446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACYZYDICD4MZQLQUVU6T3YLN7WTAVCNFSM6AAAAABBDYNU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZHA4DCNBUGY . You are receiving this because you authored the thread.Message ID: @.***>

ahmetb commented 11 months ago

It's used for testing the correctness of the manifest locally without sending a PR, so sha256 validation is part of that.

grosser commented 11 months ago

yeah, but allowing it to be missing could be nice if I want to test everything else except the sha also allows pointing to a generic latest.zip

On Tue, Dec 26, 2023 at 9:45 PM Ahmet Alp Balkan @.***> wrote:

It's used for testing the correctness of the manifest locally without sending a PR, so sha256 validation is part of that.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/krew/issues/846#issuecomment-1869970031, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACYZ4FRM56CXANGNHTXETYLOYW3AVCNFSM6AAAAABBDYNU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZHE3TAMBTGE . You are receiving this because you authored the thread.Message ID: @.***>

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 6 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/krew/issues/846#issuecomment-2131010734): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.