search

kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.42k stars 369 forks source link

support uninstall with --manifest-url #848

Closed grosser closed 6 months ago

grosser commented 11 months ago

I installed my new plugin with --manifest-url and now I want to remove it.

It's not intuitive

kubectl krew uninstall --manifest-url https://raw.githubusercontent.com/grosser/kubectl-patch-all/main/krew.yaml
unknown flag: --manifest-url
kubectl krew uninstall kubectl-patch-all
failed to uninstall plugin kubectl-patch-all: plugin is not installed
kubectl krew list
detached/patch-all  v0.0.1
kubectl krew uninstall detached/patch-all
uninstall command does not support INDEX/PLUGIN syntax; just specify PLUGIN
kubectl krew uninstall patch-all
... finally worked ...

cc @ahmetb from https://github.com/kubernetes-sigs/krew/pull/429

ahmetb commented 11 months ago

I'm inclined to say it's largely intuitive to me and I haven't heard any complaints about this over the years. :) This might be a matter of taste, especially given the CLI interface is reasonably easy to scan and there is a user guide.

grosser commented 11 months ago

If it's easy to add it would be nice for completeness

On Tue, Dec 26, 2023, 6:14 PM Ahmet Alp Balkan @.***> wrote:

I'm inclined to say it's largely intuitive to me and I haven't heard any complaints about this over the years. :) This might be a matter of taste, especially given the CLI interface is reasonably easy to scan and there is a user guide.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/krew/issues/848#issuecomment-1869882291, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACYZZ6YDZR4EKNHIIWYJTYLN76ZAVCNFSM6AAAAABBDY2MO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZHA4DEMRZGE . You are receiving this because you authored the thread.Message ID: @.***>

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 6 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/krew/issues/848#issuecomment-2130745506): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.