kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.41k stars 369 forks source link

Update to Go 1.22 and latest Go dependencies #854

Closed embik closed 7 months ago

embik commented 7 months ago

This PR does a couple of things:

  1. Bump the Go version installed in CI to 1.22. Go 1.20 is EOL and won't receive further updates.
  2. Update various k8s.io dependencies. In specific, client-go was using the old v11.0.0 version, now it uses the 1.29 version of the library.
  3. Update spf13/cobra from 1.8 to 1.9.
  4. Update golangci-lint and fix code that newer linter versions complain about.

Basically, spring cleaning for the code base.

k8s-ci-robot commented 7 months ago

Welcome @embik!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

ahmetb commented 7 months ago

/lgtm /approve Thanks!

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/krew/blob/master/OWNERS)~~ [ahmetb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment