search

kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.41k stars 369 forks source link

Document Homebrew option for MacOS #858

Closed ghost closed 4 months ago

ghost commented 5 months ago

Fixes #... Related issue: #...

linux-foundation-easycla[bot] commented 5 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasadaamos Once this PR has been reviewed and has the lgtm label, please assign ahmetb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/krew/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 5 months ago

Welcome @kasadaamos!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

ahmetb commented 5 months ago

This is currently intentionally not documented, as Krew doesn't manage and update itself when installed via Homebrew. We also have no control or release automation for Homebrew at the moment. So this may require some thinking. But I'm not strongly against it.

ghost commented 5 months ago

This is currently intentionally not documented, as Krew doesn't manage and update itself when installed via Homebrew. We also have no control or release automation for Homebrew at the moment. So this may require some thinking. But I'm not strongly against it.

EDITED: Would it address the points you raise if I added them (these points) to the documentation in the proposed PR?

ghost commented 4 months ago

This isn't going anywhere, closing.