Open paulgmiller opened 3 days ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: paulgmiller Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @paulgmiller. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
I see you found a lot of cleanups, can you please split those commits and send in a different PR ... the Interface looks pretty neat, seems a good idea
Described alot more of intent in #121
Very much a "lets see if this makes sense" rather than "please review for merging" PR.