kubernetes-sigs / kube-network-policies

Kubernetes network policies
Apache License 2.0
36 stars 14 forks source link

Seperate packet interception into seperate interface/package to get it out of controller. #122

Open paulgmiller opened 3 days ago

paulgmiller commented 3 days ago

Described alot more of intent in #121

Very much a "lets see if this makes sense" rather than "please review for merging" PR.

k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: paulgmiller Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kube-network-policies/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 days ago

Hi @paulgmiller. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aojea commented 2 days ago

I see you found a lot of cleanups, can you please split those commits and send in a different PR ... the Interface looks pretty neat, seems a good idea