search

kubernetes-sigs / kube-network-policies

Kubernetes network policies
Apache License 2.0
21 stars 8 forks source link

don't use obscure env variables and use flags #44

Closed aojea closed 3 weeks ago

aojea commented 3 weeks ago

Let's do the things the right way

Fixes: #43

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-network-policies/blob/main/OWNERS)~~ [aojea] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aojea commented 3 weeks ago

/assign @danwinship

danwinship commented 3 weeks ago

/lgtm /hold if you want to update the error message but maybe that was intentional

k8s-ci-robot commented 3 weeks ago

New changes are detected. LGTM label has been removed.

aojea commented 3 weeks ago

/lgtm /hold if you want to update the error message but maybe that was intentional

/hold cancel

fixed the env variable problem and added the error to the log, once CI passes we should be good to go and I fix existing release