search

kubernetes-sigs / kube-scheduler-simulator

The simulator for the Kubernetes scheduler
Apache License 2.0
795 stars 135 forks source link

Remove no longer needed resource service #305

Closed 196Ikuchil closed 1 year ago

196Ikuchil commented 1 year ago

What type of PR is this?

/area simulator /kind cleanup

What this PR does / why we need it:

We no longer need each resource service.

Which issue(s) this PR fixes:

closes #139 #233

Special notes for your reviewer:

/label tide/merge-method-squash

196Ikuchil commented 1 year ago

Wait for #304

/hold

sanposhiho commented 1 year ago

@196Ikuchil Sorry about the delay, FYI https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/304 is merged

196Ikuchil commented 1 year ago

/unhold

196Ikuchil commented 1 year ago

Thanks! Please review this? 🙏

/assign @sanposhiho

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 196Ikuchil, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/OWNERS)~~ [196Ikuchil,sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment