sanposhiho
commented
1 year ago /kind bug
Closed MichBenedetti closed 7 months ago
sanposhiho
commented
1 year ago /kind bug
sanposhiho
commented
1 year ago /area simulator /assign
k8s-triage-robot
commented
9 months ago The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale is appliedlifecycle/stale was applied, lifecycle/rotten is appliedlifecycle/rotten was applied, the issue is closedYou can:
/remove-lifecycle stale/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
tmishina
commented
9 months ago I faced same issue and now unable to test my custom plugin. Is there any plan to fix the issue, or any hint or workaround to avoid the issue? Thanks!
sanposhiho
commented
9 months ago /remove-lifecycle stale /priority next-release
Sorry for keeping it for a long time. I'll get a time investigating this before our next patch release.
sanposhiho
commented
9 months ago https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/332 should fix this issue.
As the PR description says, the core problem of the issue is that we didn't document one required step for registeredOutOfTreeMultiPointName. The PR will eliminate the undocumented step though, while waiting for the PR to get merged, you can fix this issue by registering your custom plugin name at registeredOutOfTreeMultiPointName like this:
outOfTreeRegistries = runtime.Registry{
nodenumber.Name: nodenumber.New,
}
registeredOutOfTreeMultiPointName = []string{
nodenumber.Name,
}@sanposhiho Thank you so much for your comment, now NodeNumber plugin works as expected. I will try again with my own custom plugin.
yz2001zzx
commented
8 months ago @tmishina how was this issue fixed? I tried editing the config like the following for the sample NodeNumber plugin-in in /kube-scheduler-simulator/simulator/scheduler/config/plugin.go as suggested above.
var (
outOfTreeRegistries = runtime.Registry{
nodenumber.Name: nodenumber.New,
}
registeredOutOfTreeMultiPointName = []string{
nodenumber.Name,
})
I still got the same status code 500 error after I added the NodeNumber plugin in the KubeSchedulerConfiguration via the GUI.
Do we have to move /kube-scheduler-simulator/simulator/docs/sample/nodenumber to somewhere?
If possible, please give some guidance with more details on how to integrate our custom plugin.
When I was trying to integrate my own custom plugin, I got the same error, so I tried the sample NodeNumber plugin but the result was the same even after adding nodenumber.Name inside registeredOutOfTreeMultiPointName = []string{}.
What I did for the NodeNumber plugin:
Modify /kube-scheduler-simulator/simulator/scheduler/config/plugin.go as suggested above;
Added the NodeNumber plugin in the KubeSchedulerConfiguration via the GUI following the GUI in https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/simulator/docs/custom-plugin.md
Any other tricks or missing step(s)? @sanposhiho
Much appreciated.
tmishina
commented
8 months ago @yz2001zzx Have you specify scheduler config in simulator/config.yaml?
# The path to a KubeSchedulerConfiguration file.
# If passed, the simulator will start the scheduler
# with that configuration. Or, if you use web UI,
# you can change the configuration from the web UI as well.
kubeSchedulerConfigPath: "docs/sample/debuggable-scheduler/scheduler.yaml"kubeSchedulerConfigPath should be an absolute path or relative path from simulator/config.yaml.
a-c-dream
commented
7 months ago @yz2001zzx Did you solve your problem? I had the same problem as you. I also modified /kube-scheduler-simulator/simulator/scheduler/config/plugin.go and I also modified simulator/config.yaml like @tmishina said but when I add NodeNumber in Web UI I still I get error code 500.
Is it possible that I have to rebuild after modifying it, but when I rebuild I get the error
@sanposhiho Can you offer some solutions?
sanposhiho
commented
7 months ago @a-c-dream Well, can you open another issue with the repro steps?
Good morning, I have a problem related to adding a custom plugin to the simulator configuration. To integrate the plugin, I followed the instructions provided in the documentation available at this link: ([https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/simulator/docs/custom-plugin.md]).
To determine if the issue was with my custom plugin or something else, I tried integrating the sample plugin as instructed, but it still throws an error. Specifically, when I add the plugin's name to the YAML file and click on apply, a generic 500 error occurs. Checking the command line, it seems that a certain "Wrapped" file is missing, as seen in the screenshots below.
What could be the problem? Is there any additional configuration that needs to be added beyond what is mentioned in the guide?