search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
83 stars 16 forks source link

chore: wazero v1.6.0 version bump #102

Closed evacchi closed 3 months ago

evacchi commented 3 months ago

Hi, this is Edoardo from the wazero team. I am opening this PR to upgrade to the latest version and will stick around to help with reviewing some PRs! If you need some help especially with Wasm feel free to ping me here or on the k8s/Gophers Slack!

This upgrades to wazero v1.6.0. This release notably introduces a new experimental optimizing compiler backend for arm64.

As compared to v1.3.0, cumulatively this upgrade brings several stability enhancements; including compiler bugs, improvements to WASI support, especially when paired with the newer Go GOOS=wasip1 backend, and fixes to a potential memory leak.

Read more on the previous release notes (v1.3.1, v1.4.0, v1.5.0)

/kind cleanup

Signed-off-by: Edoardo Vacchi evacchi@users.noreply.github.com

goos: darwin
goarch: arm64
pkg: sigs.k8s.io/kube-scheduler-wasm-extension/internal/e2e/scheduler
                                       │ bench-example-before.txt │      bench-example-after.txt       │
                                       │          sec/op          │    sec/op     vs base              │
Example_NodeNumber/Simple/New-10                     65.91m ±  1%   65.63m ±  0%       ~ (p=0.093 n=6)
Example_NodeNumber/Simple/Run-10                     160.9µ ± 23%   162.6µ ± 21%       ~ (p=0.818 n=6)
Example_NodeNumber/Simple_Log/New-10                 65.96m ±  0%   65.49m ±  1%  -0.71% (p=0.026 n=6)
Example_NodeNumber/Simple_Log/Run-10                 180.0µ ±  6%   180.4µ ±  5%       ~ (p=0.937 n=6)
Example_NodeNumber/Advanced/New-10                   79.86m ±  1%   78.02m ±  0%  -2.30% (p=0.002 n=6)
Example_NodeNumber/Advanced/Run-10                   74.40µ ±  0%   74.17µ ±  0%  -0.31% (p=0.002 n=6)
Example_NodeNumber/Advanced_Log/New-10               79.55m ±  1%   78.30m ±  1%  -1.57% (p=0.002 n=6)
Example_NodeNumber/Advanced_Log/Run-10               82.37µ ±  0%   81.96µ ±  0%  -0.50% (p=0.002 n=6)
geomean                                              2.893m         2.876m        -0.57%
evacchi commented 3 months ago

uhm maybe it should be

/kind feature

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evacchi, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment