Closed gonzaloserrano closed 12 months ago
linux-foundation-easycla[bot]
commented
12 months ago 
The committers listed above are authorized under a signed CLA.
k8s-ci-robot
commented
12 months ago Welcome @gonzaloserrano!
It looks like this is your first PR to kubernetes-sigs/kube-scheduler-wasm-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kube-scheduler-wasm-extension has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
codefromthecrypt
commented
12 months ago ps the whole line in guest/filter.go is incorrect as the syntax drifted.. so copy/paste over that from your example/main.go update.
kerthcet
commented
12 months ago /approve
k8s-ci-robot
commented
12 months ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: codefromthecrypt, gonzaloserrano, kerthcet
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix a typo.
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?
NONE