make sure if there's no diff in ci

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.

Apache License 2.0

110 stars 22 forks source link

make sure if there's no diff in ci #111

Closed sanposhiho closed 5 months ago

sanposhiho commented 5 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Make CI fail if any generated .wasm isn't up-to-date.
Make make testcase fail if any generation fails.

Which issue(s) this PR fixes:

Fixes #97

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

n/a

sanposhiho commented 5 months ago

/cc @utam0k @Gekko0114

Gekko0114 commented 5 months ago

/lgtm Thank you so much for taking this issue!!

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gekko0114, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment