Support SharedLister for NodeInfo

sanposhiho commented 3 months ago

What type of PR is this?

/kind feature /kind cleanup

What this PR does / why we need it:

Improve how the guest caches nodes for a better efficiency.
- And, wire SharedLister().NodeInfos() and cached Nodes.
Support SharedLister for NodeInfo.
- Only the basic node's data and ImageStates is supported for now. We can support other fields later.
Add ImageLocality plugin, ported from the in-tree plugin.

Which issue(s) this PR fixes:

Fixes #70 Part of #73

Special notes for your reviewer:

Does this PR introduce a user-facing change?

SharedLister for NodeInfo is supported.

What are the benchmark results of this change?

                                       │  before.txt  │              after.txt               │
                                       │    sec/op    │    sec/op      vs base               │
Example_NodeNumber/Simple/New-12         563.2m ±  2%    584.6m ±  3%   +3.82% (p=0.015 n=6)
Example_NodeNumber/Simple/Run-12         93.41µ ± 26%   108.65µ ± 12%        ~ (p=0.093 n=6)
Example_NodeNumber/Simple_Log/New-12     552.2m ±  2%    614.9m ± 16%  +11.35% (p=0.002 n=6)
Example_NodeNumber/Simple_Log/Run-12     109.4µ ±  8%    108.9µ ± 28%        ~ (p=0.485 n=6)
Example_NodeNumber/Advanced/New-12       633.0m ±  3%    660.1m ±  3%   +4.28% (p=0.002 n=6)
Example_NodeNumber/Advanced/Run-12       37.80µ ± 25%    38.30µ ±  4%        ~ (p=0.589 n=6)
Example_NodeNumber/Advanced_Log/New-12   649.9m ± 12%    648.1m ±  5%        ~ (p=0.937 n=6)
Example_NodeNumber/Advanced_Log/Run-12   42.80µ ±  3%    44.93µ ± 10%   +4.98% (p=0.002 n=6)
geomean                                  6.175m          6.486m         +5.03%

sanposhiho commented 2 months ago

/cc @Gekko0114 @utam0k

sanposhiho commented 2 months ago

@Gekko0114 Addressed or replied to your comments.

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gekko0114, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sanposhiho commented 2 months ago

Merging the PR.

@Gekko0114 (fyi @utam0k ) This repo is under development anyway and doesn't need to be conservative. So, let's not wait for other people's approval like k/k. I mean not only PRs from me, but also ones from anyone. I know people besides me cannot /approve though, I'll basically just put the approval for PRs that either of you put the stamp.

kubernetes-sigs / kube-scheduler-wasm-extension