search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
109 stars 22 forks source link

fix: add missing replace for k8s.io/endpointslice to v0.30.4 #129

Closed dejanzele closed 1 week ago

dejanzele commented 1 week ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes missing replace for k8s.io/endpointslice to version v0.30.4. Otherwise it tries to fetch v0.0.0 and complains about unknown revision.

How to replicate:

  1. Go to scheduler or internal/e2e folders
  2. Run go list -modfile=go.mod -m -json -mod=mod all 
    $ go list -modfile=go.mod -m -json -mod=mod all
go: k8s.io/endpointslice@v0.0.0: invalid version: unknown revision v0.0.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

dejanzele commented 1 week ago

/cc @sanposhiho

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dejanzele, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment