search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
109 stars 22 forks source link

feat: add support for GetLabels and GetAnnotations in metadata #131

Closed dejanzele closed 1 week ago

dejanzele commented 1 week ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for GetLabels and GetAnnotations in the Metadata interface so labels and annotations can be fetched for pods and nodes.

This will be required when porting in-tree plugins as some of them need access to labels and annotations.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dejanzele, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment