kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
110 stars 22 forks source link

Make the guest interface very similar to existing scheduler plugins interface #15

Closed sanposhiho closed 1 year ago

sanposhiho commented 1 year ago

What would you like to be added:

people can implement wasm based plugins in very similar interface of the plugins in scheduling framework.

Why is this needed:

You can see how to implement the guest in the example. It's now quite different from how we implement the scheduler plugins.

To reduce the learning cost for people and to make it easy to convert from existing plugins to wasm-based plugins, we want to reduce the difference from the scheduler's plugin interface as much as possible.

Completion requirements:

This enhancement requires the following artifacts:

The artifacts should be linked in subsequent comments.

codefromthecrypt commented 1 year ago

dependent on #13, but sounds good

sanposhiho commented 1 year ago

/assign

sanposhiho commented 1 year ago

/close

I now know it's a quite bad/impossible idea to make both interface same. We can come back here when the allocation or GC performance gets improved, but for now, just close it

k8s-ci-robot commented 1 year ago

@sanposhiho: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/issues/15#issuecomment-1576601351): >/close > >I now know it's a quite bad/impossible idea to make both interface same. We can come back here when the allocation or GC performance gets improved, but for now, just close it Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codefromthecrypt commented 1 year ago

ps this makes things closer, and the important thing is benchmark driven and still get a lot closer to the host interface. https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/32