search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
86 stars 17 forks source link

add: add the copyright header #20

Closed sanposhiho closed 11 months ago

sanposhiho commented 11 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds the copyright header, which we usually add even in the sub projects.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE
sanposhiho commented 11 months ago

@kerthcet Could you check this first? Then I'll add the copyright header in each PR.

kerthcet commented 11 months ago

Maybe the folder migration first https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/18 for you have to modify again. but I'm ok with both approaches.

kerthcet commented 11 months ago

/lgtm /approve /hold

Leave it to you.

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codefromthecrypt, kerthcet, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [kerthcet,sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sanposhiho commented 11 months ago

@kerthcet Sorry for bothering you again, PTAL 🙏

kerthcet commented 11 months ago

My pleasure. /lgtm

sanposhiho commented 11 months ago

/unhold