Closed anuraaga closed 1 year ago
Welcome @anuraaga!
It looks like this is your first PR to kubernetes-sigs/kube-scheduler-wasm-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kube-scheduler-wasm-extension has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/cc @codefromthecrypt
@anuraaga: GitHub didn't allow me to request PR reviews from the following users: codefromthecrypt.
Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: anuraaga, codefromthecrypt, sanposhiho
The full list of commands accepted by this bot can be found here.
The pull request process is described here
thanks for lighting turn-around as this drifts my local stuff and I was a bit anxious when it would land. All good!
What type of PR is this?
/label tide/merge-method-squash
What this PR does / why we need it:
Preallocates a call stack for wasm invocation to reduce allocations during the filter hot path. This improves performance of function invocation a little bit.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This project may not be at a stage for such small optimizations so no need to proceed if so - I saw some perf work happening so figured it may help to send it
Does this PR introduce a user-facing change?
What are the benchmark results of this change?