kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
86 stars 17 forks source link

Updates wazero to 1.2.1 #41

Closed codefromthecrypt closed 11 months ago

codefromthecrypt commented 11 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We're constantly tracking performance concerns and updating to the latest wazero release makes notable improvements without any change to the guest.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Performance related changes in the latest patch were thanks to @ncruces

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

goos: darwin
goarch: arm64
pkg: sigs.k8s.io/kube-scheduler-wasm-extension/internal/e2e
                                               │  v1.2.0.txt  │            v1.2.1.txt             │
                                               │    sec/op    │   sec/op     vs base              │
PluginFilter/noop-wat/params:_small-12           267.4n ±  2%   257.6n ± 4%  -3.65% (p=0.024 n=6)
PluginFilter/noop-wat/params:_real-12            270.4n ±  1%   270.1n ± 1%       ~ (p=0.623 n=6)
PluginFilter/noop/params:_small-12               333.2n ±  1%   329.2n ± 0%  -1.19% (p=0.002 n=6)
PluginFilter/noop/params:_real-12                337.0n ±  0%   336.2n ± 1%       ~ (p=0.701 n=6)
PluginFilter/test/params:_small-12               6.770µ ±  0%   6.279µ ± 0%  -7.25% (p=0.002 n=6)
PluginFilter/test/params:_real-12                122.6µ ±  5%   114.7µ ± 1%  -6.51% (p=0.002 n=6)
PluginScore/noop-wat/params:_small-12            256.2n ±  2%   257.8n ± 0%       ~ (p=0.327 n=6)
PluginScore/noop-wat/params:_real-12             260.2n ±  1%   260.6n ± 2%       ~ (p=0.331 n=6)
PluginScore/noop/params:_small-12                374.0n ±  1%   375.4n ± 1%       ~ (p=0.626 n=6)
PluginScore/noop/params:_real-12                 343.2n ±  1%   348.3n ± 1%  +1.49% (p=0.004 n=6)
PluginScore/test/params:_small-12                3.786µ ±  1%   3.604µ ± 0%  -4.82% (p=0.002 n=6)
PluginScore/test/params:_real-12                 43.48µ ± 16%   46.18µ ± 1%       ~ (p=0.394 n=6)
PluginFilterAndScore/noop-wat/params:_small-12   378.8n ±  3%   376.1n ± 1%       ~ (p=0.061 n=6)
PluginFilterAndScore/noop-wat/params:_real-12    382.1n ±  1%   380.9n ± 0%       ~ (p=0.074 n=6)
PluginFilterAndScore/noop/params:_small-12       576.7n ±  1%   578.0n ± 1%       ~ (p=0.260 n=6)
PluginFilterAndScore/noop/params:_real-12        543.1n ±  1%   543.4n ± 0%       ~ (p=0.509 n=6)
PluginFilterAndScore/test/params:_small-12       10.62µ ±  0%   10.06µ ± 1%  -5.23% (p=0.002 n=6)
PluginFilterAndScore/test/params:_real-12        176.5µ ±  0%   168.0µ ± 1%  -4.80% (p=0.002 n=6)
geomean                                          1.450µ         1.429µ       -1.48%
k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codefromthecrypt, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sanposhiho commented 11 months ago

/lgtm