chore: fix comments and make the preFilter function unexported

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.

Apache License 2.0

86 stars 17 forks source link

chore: fix comments and make the preFilter function unexported #47

Closed sanposhiho closed 10 months ago

sanposhiho commented 11 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

minor fixes that I noticed during reading https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/43

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

N/A

codefromthecrypt commented 11 months ago

/lgtm /merge

sanposhiho commented 10 months ago

rebased

kerthcet commented 10 months ago

/lgtm /approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codefromthecrypt, kerthcet, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [codefromthecrypt,kerthcet,sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment