k8s-ci-robot
commented
1 year ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: codefromthecrypt, sanposhiho
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [codefromthecrypt,sanposhiho]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
What type of PR is this?
/kind feature
What this PR does / why we need it:
Before, we had no implementation for cyclestate. This implements it guest side with a simple map.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
After feedback, I'll add unit tests and a new benchmark of reading state values.
Details on preemption are thanks to @sanposhiho who collected these notes over a few weeks offline.
Does this PR introduce a user-facing change?
NONE
What are the benchmark results of this change?
TBD after review