Closed codefromthecrypt closed 10 months ago
sorry I will fix the tinygo test.
yeah can't test panics with tinygo+wasm yet. I'll change accordingly https://github.com/tinygo-org/tinygo/issues/2914
tests pass re-running benchmark as I had to change the tinygo impl a bit
bench is still a lot better. PTAL!
Whoops, I submited the review in a middle. Wait a min for the full review.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: codefromthecrypt, sanposhiho
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind cleanup /kind documentation
What this PR does / why we need it:
This adds
api.Plugin
as a base type for guest plugins. This is similar toframework.Plugin
, but doesn't yet defineName()
as there's no purpose for it. Notes on that are added to RATIONALE.md.This mostly gets the guest SDK looking much more like the framework one. This also makes it easier to test for misconfiguration, such as registering multiple instances of plugins.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE because it isn't user-ready yet!
What are the benchmark results of this change?