Closed codefromthecrypt closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: codefromthecrypt, sanposhiho
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds a configuration key guestConfig to
wasm.PluginConfig
. The contents of this are readable by the guest usingHost.GetConfig()
.This is used by the NodeNumber plugin, to indicate reverse scoring. Specifically, the guest was re-written to unmarshal JSON as the upstream plugin does.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This implements the approach mentioned here. Logging can be done in a later change similarly https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/59#issuecomment-1646511509
Does this PR introduce a user-facing change?
NONE
What are the benchmark results of this change?