kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
83 stars 16 forks source link

guest: Add proto.Metadata and fix prefilter unmarshalling #65

Closed codefromthecrypt closed 9 months ago

codefromthecrypt commented 9 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This adds proto.Metadata type which can later be used for logging, metrics or stringer functions. This also fixes a prefilter unmarshal bug where we used the wrong host function to decode the data.

This also updates wazero patch, which isn't related, but saves a PR.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

goos: darwin
goarch: arm64
pkg: sigs.k8s.io/kube-scheduler-wasm-extension/internal/e2e/scheduler
                          │ before.txt  │              now.txt               │
                          │   sec/op    │    sec/op     vs base              │
Example_NodeNumber/New-12   74.18m ± 1%   73.66m ±  1%       ~ (p=0.180 n=6)
Example_NodeNumber/Run-12   46.28µ ± 1%   46.36µ ± 10%       ~ (p=0.394 n=6)
geomean                     1.853m        1.848m        -0.26%
k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codefromthecrypt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [codefromthecrypt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sanposhiho commented 9 months ago

/lgtm /unhold