Closed sanposhiho closed 1 year ago
/cc @codefromthecrypt
@sanposhiho: GitHub didn't allow me to request PR reviews from the following users: codefromthecrypt.
Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.
Maybe you can add a test that shows hot to do the following flow? This will help make sure it still works. The test may need to be in the plugin module, in order to avoid leaking v1 deps to the guest.
v1.Pod
to api.IoK8SApiCoreV1Pod
api.IoK8SApiCoreV1Pod
to protoapi.IoK8SApiCoreV1Pod
from protov1.Pod
(optional)[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: codefromthecrypt, sanposhiho
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I made notes on #6 and not sure how much of https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/7#issuecomment-1556129351 is needed. Basically, first thing is to make sure we can build tinygo wasm which reads it. For some reason my laptop doesn't respond when trying to build, both 0.27 and dev version of tinygo.
In #6 I added code to generate the MarshallVT functions
It's included in #6.
/close
@sanposhiho: Closed this PR.
PR needs rebase.
What type of PR is this?
/kind feature
What this PR does / why we need it:
add protobuf definition + generated Golang protobuf code which is buildable with TinyGo. We cannot use the proto definitions in kubernetes/api because it depends on many stuff which aren't buildable with TinyGo. (Hopefully, it'll be buildable in the future version of TinyGo.)
The protobuf definition is generated from https://github.com/nytimes/openapi2proto with the patch. And use
google.golang.org/protobuf/cmd/protoc-gen-go
for Golang code generation.As you see in ./kubernetes/proto/go.mod, it only depends on
google.golang.org/protobuf
, which is buildable with TinyGo.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?