search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
83 stars 16 forks source link

Support all extension points #72

Open sanposhiho opened 6 months ago

sanposhiho commented 6 months ago

Note that this issue's scope is only the interface support. For example, you may think that PostFilterPlugin is useless unless some functions in framework.Handle is supported. That might be true, but https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/issues/73 does the support, not this issue.

sanposhiho commented 6 months ago

I'll take PreFilterExtensions.

Gekko0114 commented 6 months ago

@sanposhiho , Can I work on PostFilterPlugin?

sanposhiho commented 6 months ago

Yes.

/assign @Gekko0114

Gekko0114 commented 5 months ago

I'll work on ScoreExtensions as well

sanposhiho commented 5 months ago

@Gekko0114 Excellent, assigned it to you. Sorry for the delay on reviews, I think I'll be able to have time in this weekend.

Gekko0114 commented 5 months ago

Since implementing extension points is interesting for me, I will work on PreBindPlugin as well :) (Please let me know if you have any comments)

sanposhiho commented 5 months ago

🙆👍

Gekko0114 commented 5 months ago

PreBindPlugin's implementation partially depends on bindPlugin, so I will implement BindPlugin at the same time

Gekko0114 commented 5 months ago

Thanks for your review! I will work on PostBindPlugin as well

utam0k commented 5 months ago

I'm newer in this field, but I'm interested in contributing to this issue. Can I pick up PreBind?

Gekko0114 commented 5 months ago

I completed prebind, so remaining item is reserve plugin I guess

sanposhiho commented 5 months ago

I should have updated the list 😅 Please choose from Reserve and PreFilterExtension

utam0k commented 5 months ago

@Gekko0114 Wow! You work very hard! Okay, can I pick the Revere plugin? I don't know if this one is suitable for the beginner... 🤔

utam0k commented 5 months ago

@sanposhiho Which one is good for the first step?

sanposhiho commented 5 months ago

Tabun Reserve.

utam0k commented 5 months ago

Please assign me to Reserver plugin😆

Gekko0114 commented 5 months ago

BTW we may miss permit plugin?

sanposhiho commented 5 months ago

🦀 Added.

utam0k commented 5 months ago

:tashikani:

sanposhiho commented 5 months ago

/assign @utam0k

sanposhiho commented 5 months ago

My interest has actually moved to #71, I'll leave from PreFilterExtensions for someone else.

sanposhiho commented 5 months ago

/unassign @sanposhiho

chansuke commented 5 months ago

I would like to work on PreFilterExtensions🤲🏻

sanposhiho commented 5 months ago

assigned 🤲🏻

sanposhiho commented 4 months ago

/priority next-release

kazukousen commented 4 months ago

Can I work on PermitPlugin ?

sanposhiho commented 4 months ago

Yes.

/assign @kazukousen @chansuke

sanposhiho commented 4 months ago

@kazukousen

Look at other people's PR to get what's needed for PermitPlugin, e.g., https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/82 Communicate in English in public (issues/PRs), and if you have a question, you can reach out to me or @Gekko0114 in the Kubernetes slack, and obviously Japanese is OK in DM if you want :)