search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
83 stars 16 forks source link

Support postBind plugin #79

Closed Gekko0114 closed 4 months ago

Gekko0114 commented 5 months ago

What type of PR is this?

/kind feature /kind api-change

What this PR does / why we need it:

Support postBind plugin

Which issue(s) this PR fixes:

Part of #72

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support postBind plugin

What are the benchmark results of this change?

Gekko0114 commented 5 months ago

Hi @sanposhiho ,

I created a PR about postBind. Could you take a look? Also I am not sure about some parts of implementation, so I left comments.

Gekko0114 commented 5 months ago

Hi @sanposhiho , Updated, PTAL again? Thanks,

sanposhiho commented 5 months ago

/assign

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gekko0114, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment