fix: use correct guest in binding cycles

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.

Apache License 2.0

109 stars 22 forks source link

fix: use correct guest in binding cycles #86

Closed sanposhiho closed 11 months ago

sanposhiho commented 11 months ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

We have to use guests in guestPool.binding during binding cycles.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

What are the benchmark results of this change?

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sanposhiho commented 11 months ago

/assign @Gekko0114

Gekko0114 commented 11 months ago

/lgtm

Thanks!