search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
83 stars 16 forks source link

Support PrefilterExtensions #92

Open chansuke opened 4 months ago

chansuke commented 4 months ago

What type of PR is this?

/kind feature /kind api-change

What this PR does / why we need it:

Added PrefilterExtensions

Which issue(s) this PR fixes:

Fixes part of #72

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support PrefilterExtensions

What are the benchmark results of this change?

k8s-ci-robot commented 4 months ago

Welcome @chansuke!

It looks like this is your first PR to kubernetes-sigs/kube-scheduler-wasm-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kube-scheduler-wasm-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

chansuke commented 3 months ago

@sanposhiho Thank you so much for the support. I've added the PrefilterExtensions. PTAL.

/assign /assign @sanposhiho

chansuke commented 3 months ago

/assign @sanposhiho

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chansuke Once this PR has been reviewed and has the lgtm label, please ask for approval from sanposhiho. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Gekko0114 commented 3 months ago

Please fix ci failures.

chansuke commented 3 months ago

Yes, I will do this tonight🙏

codefromthecrypt commented 3 months ago

y'all are on a roll!

Gekko0114 commented 3 months ago

@chansuke Could you fix CI failure? Seems some of cases failed

Gekko0114 commented 3 months ago

/label tide/merge-method-squash

Gekko0114 commented 3 months ago

When you change the code under guest/, you need to update wasm file as well.

Gekko0114 commented 3 months ago

@chansuke I found why your test fails. Please take a look. BTW, you can resolve comments once you fixed it.

chansuke commented 3 months ago

@Gekko0114 I appreciate your comment. :pray: I've passed the podInfoToAdd and nodeInfo but still having the issue... I keep debugging