search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
255 stars 84 forks source link

Re-use the RESTMapper from the ctrl.Manager in the dynamic watcher #171

Closed justinsb closed 3 years ago

justinsb commented 3 years ago

Though this is a breaking change, reusing the RESTMapper avoids repeated discovery.

Also mark the watch functions as deprecated to support a future move to an internal package.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atoato88 commented 3 years ago

/lgtm