search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
255 stars 84 forks source link

Fix namespace setting with direct applier #173

Closed justinsb closed 3 years ago

justinsb commented 3 years ago

The direct-applier was not setting the namespace correctly; we reuse the SetNamespace visitor to do so.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atoato88 commented 3 years ago

Codes for adding Namespace is LGTM. And I commented on manifest validation above.

atoato88 commented 3 years ago

/lgtm