search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
255 stars 84 forks source link

Make atoato88 an approver #177

Closed justinsb closed 3 years ago

justinsb commented 3 years ago

atoato88 has demonstrated deep understanding of the code, and has a track record of participation. Thank you atoato88!

justinsb commented 3 years ago

@atoato88 would you like to become an approver for the project? You have a long track record here that justifies it IMO.

/assign johnsonj for approval

/hold for atoato88 to accept

atoato88 commented 3 years ago

I'm so appreciate. Yes please😄

Besides here, I would like to continue reviewing cluster-addons also. 😉

stealthybox commented 3 years ago

You have a long track record here

+1

Thanks for your efforts here @atoato88

johnsonj commented 3 years ago

/lgtm

johnsonj commented 3 years ago

/approve

Thank you @atoato88 for your continued, high quality contributions and being part of the project!

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnsonj, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [johnsonj,justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 3 years ago

Looks like consensus - thank you all and @atoato88 :-)

/hold cancel