Closed tomasaschan closed 2 years ago
Welcome @tomasaschan!
It looks like this is your first PR to kubernetes-sigs/kubebuilder-declarative-pattern 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubebuilder-declarative-pattern has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @tomasaschan. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb, tomasaschan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
Before this fix, a declarative controller using
declarative.WithOwner(declarative.SourceAsOwner)
will end up in an infinite reconciliation loop if any of the manifests in the package do not support having the declarative object as its owner.For example, consider a namespaced declarative object
foo/foo
of typeFoo
, installing a package that adds a few objects (say, twoBar
s) in the same namespace plus another object (say, aBaz
) in a fixed namespacequx
. With the old behavior of this reconciler, the following happens:The reconciler creates all objects in the package, setting owner references to an object with the same group, version, kind and name as the declarative object, and the same namespace as each respective object from the package. In other words, we get two
Bar
s infoo
owned byfoo/foo
, and aBaz
inqux
owned byqux/foo
.Since
qux/foo
does not exist, the API server decides that it must have been deleted, and that meansqux/baz
should also be deleted (its owner no longer exists).The reconciler is notified, and determines that
qux/baz
is missing, re-adding it again with an owner reference toqux/foo
.Go back to step 2.
With the change in this PR, the reconciler will instead skip setting an owner reference on
qux/foo
, avoiding the infinite loop at the cost ofqux/foo
now being a "dangling" object; if/when the declarative objectfoo/foo
is deleted,qux/foo
will be left untouched in the cluster.Which issue(s) this PR fixes: Fixes #176