kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
257 stars 85 forks source link

refactory updating status mechanism, status func could handle error #199

Closed xuzhenglun closed 2 years ago

xuzhenglun commented 2 years ago

What this PR does / why we need it:

related with #197:

  1. refractory mechanism of updating status: a. allow status Reconciled method known if error happened, so that user could be able to submit an error to CR status field or launch an Event; b. maybe it's related with #190

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

k8s-ci-robot commented 2 years ago

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atoato88 commented 2 years ago

/ok-to-test

xuzhenglun commented 2 years ago

/test

k8s-ci-robot commented 2 years ago

@xuzhenglun: The /test command needs one or more targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/199#issuecomment-1022802277): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xuzhenglun commented 2 years ago

/test all

atoato88 commented 2 years ago

/lgtm I think contents of this PR don't have any side effects, so It's OK. Reconciled function doesn't use error object on 4th args at here and here. But on other PR, we can use this object to write more information on status, I think.

atoato88 commented 2 years ago

/assign @justinsb Could you review this?

xuzhenglun commented 2 years ago

@justinsb please take a look when you are convenient.

atoato88 commented 2 years ago

/approve This is good update for this repository and confirmed that tests past successfully. I approve this.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment