Closed xuzhenglun closed 2 years ago
Hi @xuzhenglun. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/test
@xuzhenglun: The /test
command needs one or more targets.
The following commands are available to trigger required jobs:
/test pull-declarative-test
Use /test all
to run all jobs.
/test all
/assign @justinsb Could you review this?
@justinsb please take a look when you are convenient.
/approve This is good update for this repository and confirmed that tests past successfully. I approve this.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: atoato88, xuzhenglun
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
related with #197:
Reconciled
method known iferror
happened, so that user could be able to submit an error to CR status field or launch an Event; b. maybe it's related with #190Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation: