search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

refactor: Use strategic merge patch #204

Closed irvifa closed 2 years ago

irvifa commented 2 years ago

What this PR does / why we need it:

Store the name of the base object, because this name may have been munged. Apply this name to the patched object.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

StrategicMergePatch.

irvifa commented 2 years ago

/assign

atoato88 commented 2 years ago

/lgtm Thanks to update.

/assign @justinsb Could you reveiw this?

irvifa commented 2 years ago

/cc @kubernetes-sigs/kubebuilder-declarative-pattern-admins

atoato88 commented 2 years ago

@justinsb Gentle ping. Could you reveiw this? This PR updates base logic for this repository and it's good for more stability, I think.

atoato88 commented 2 years ago

/approve Tests by prow passed in successfully, it's OK to merge.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment