search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Add unit test for loaders/types #205

Closed atoato88 closed 2 years ago

atoato88 commented 2 years ago

What this PR does / why we need it:

This PR adds more unit tests for pkg/patterns/addon/pkg/loaders/types.go. As of now, this repository should have more unit tests, because of codebase quality and readability for logics which already exists.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Additional documentation:

atoato88 commented 2 years ago

/assign @justinsb Could you review this?

justinsb commented 2 years ago

Great stuff, thanks @atoato88 - having good test coverage will really help us as we evolve & stabilize the library!

/approve /lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88,justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment