search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Add unit test for loaders/fs #207

Closed atoato88 closed 2 years ago

atoato88 commented 2 years ago

What this PR does / why we need it:

This PR adds more unit tests for pkg/patterns/addon/pkg/loaders/fs.go.

Which issue(s) this PR fixes: NONE

Special notes for your reviewer: NONE

Additional documentation: related to: #205

justinsb commented 2 years ago

Interesting observation on the git urls, but this PR looks good to me.

I think if we wanted to change git// to .git// we should probably bump the version; better versioning is something I've been wanting to do for a while, so maybe this is the time!

/approve /lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88,justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment