search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
256 stars 85 forks source link

check object scope before fetching #213

Closed xuzhenglun closed 2 years ago

xuzhenglun commented 2 years ago

What this PR does / why we need it:

if metadata.namespace on Cluster-level resource(such as ClusterRole) is set, kubectl apply will not report an error and just ignore it. But when I submit via Controller, it failed and report an error like resource xxx is not found.

After some time I dug, I realize that namespace is joined into the URL. So maybe we should check whether the resource is Cluster-level, and ignore metadata.namespace if it's positive.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

k8s-ci-robot commented 2 years ago

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xuzhenglun commented 2 years ago

/assign atoato88

atoato88 commented 2 years ago

/ok-to-test

xuzhenglun commented 2 years ago

ping @atoato88

I rebased this PR and CI is passed. Please leave an comment when you are convenient.

atoato88 commented 2 years ago

/lgtm /approve Thank you to rebase :smile:

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment