search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

RESTMapper optimized for controllers #218

Closed justinsb closed 2 years ago

justinsb commented 2 years ago

The default RESTMappers are very optimized around the kubectl use-case, where most of the time controllers only need to map GVK -> GVR to support an apply operation.

Start adding a RESTMapper optimized around this specific use-case.

justinsb commented 2 years ago

I'm curious how much this could be solved in k/k directly, since that could more useful in general. Thanks!

Yes - absolutely - we should use the subprojects... let's prove that it works in k-sigs, then promote it to k/k (e.g. client-go). If we need something from e.g. the apiserver to improve things, we'll figure that out here!

apelisse commented 2 years ago

Thanks, /lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment