Closed everettraven closed 2 years ago
Welcome @everettraven!
It looks like this is your first PR to kubernetes-sigs/kubebuilder-declarative-pattern 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubebuilder-declarative-pattern has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @everettraven. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: everettraven
To complete the pull request process, please assign justinsb after the PR has been reviewed.
You can assign the PR to them by writing /assign @justinsb
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/ok-to-test
/retest
/retest
Hi @everettraven,
Could this one be PR now and no longer a draft so that we can move forward?
Also, can we update the title like we do for kubebuilder ⚠️ upgrade from 1.23 to 1.24
@camilamacedo86 I provided the information that I had found to @NikhilSharmaWe and @NikhilSharmaWe has been updating their PR to get it working. I figured it would be nice allow @NikhilSharmaWe to update their PR and get that one merged instead since they had already done work on it and I just helped out a bit :)
However if @NikhilSharmaWe would prefer that we go ahead and move along with this one as opposed to #217 then I would be happy to convert this to a regular PR and adjust the title
closing this one in favor of https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/217
Draft PR for testing k8s 1.24 bump changes