Closed atoato88 closed 2 years ago
/rename Set dummy name for apply on direct.go
/retitle Set dummy name for apply on direct.go
oh, command miss...
/assign @justinsb I created this for fixing #224 which is noted on here. Could you review this?
I think that this PR fixes issue, but it's rough approach. Could you suggest some ideas for this?
@atoato88 thanks for looking into this!
@justinsb Gentle ping: Can you take a look at this when you get the chance? This impacts us as well.
Thanks for fixing @atoato88 ... this was an unfortunate change in a library that was supposed to simplify things :-( With server-side-apply, I'm not sure how much it is helping us. We also have https://github.com/kubernetes/kops/pull/13753/files in another project (kOps) which could be a better applier, and our appliers are now pluggable.
In any case, thanks for this and sorry about the delay!
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: atoato88, justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thank you to mention me and suggestion for good implementation. I'll check taht 😄
Awesome, thank you both!
What this PR does / why we need it:
This PR sets filename field with dummy name for appling manifest. Before this PR, operator said errors followings:
ERROR applying manifest {"error": "error getting apply options: must specify one of -f and -k"}
I checked that this PR fixed current bug, but it's pretty rough, I think.
Which issue(s) this PR fixes:
Fixes #224
Special notes for your reviewer:
Currently, update is pretty rough, but root cause is discovered. Feel free to comment more good approach.
Additional documentation: NONE