Closed xuzhenglun closed 2 years ago
Hi @xuzhenglun. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Thank you to create, and I'm glad that this PR has unit test! :smile: It help to understand the update.
/lgtm
@atoato88
shall we make this progress go-ahead?
Sorry for delay and thanks for fixing this!
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb, xuzhenglun
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
below YAML separator is valid for
kubectl
but does not work in this repo.In current behavior,
really doc here
will treat as a part ofprevious doc
, andreally doc here
will be eaten inyaml.Unmarshal
later.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation: