search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
256 stars 85 forks source link

fix decode multi YAML doc #226

Closed xuzhenglun closed 2 years ago

xuzhenglun commented 2 years ago

What this PR does / why we need it:

previous doc
--- # THIS IS A COMMENT
---   
really doc here

below YAML separator is valid for kubectl but does not work in this repo.

  1. the first separator has some comments.
  2. the second separator has white space at the end of it.

In current behavior, really doc here will treat as a part of previous doc, and really doc here will be eaten in yaml.Unmarshal later.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

k8s-ci-robot commented 2 years ago

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atoato88 commented 2 years ago

/ok-to-test

Thank you to create, and I'm glad that this PR has unit test! :smile: It help to understand the update.

atoato88 commented 2 years ago

/lgtm

xuzhenglun commented 2 years ago

@atoato88

shall we make this progress go-ahead?

justinsb commented 2 years ago

Sorry for delay and thanks for fixing this!

/approve /lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment