Don't log an error if there are no errors during apply

[jcanseco]

What this PR does / why we need it:

This commit fixes an issue where operators would log the following error even when the apply succeeds without error:

{
    "severity":"error",
    "timestamp":"2022-07-06T21:24:32.759Z",
    "msg":"applying manifest",
    "error":"error from apply yamls: %!w(<nil>)",
    "errorCauses":[{"error":"error from apply yamls: %!w(<nil>)"}]
}

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

The issue seems to have originated from https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/223.

[k8s-ci-robot]

Welcome @jcanseco!

It looks like this is your first PR to kubernetes-sigs/kubebuilder-declarative-pattern 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder-declarative-pattern has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @jcanseco. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[jcanseco]

/unassign @droot

[jcanseco]

/assign @atoato88

[jcanseco]

Hi @atoato88 could I ask you to review this instead? @droot is no longer an active maintainer apparently.

[atoato88]

Thank you to mention me. I'll check that. But it may be able to review early next week sorry for my delay.

[jcanseco]

No problem; that works for us. Thank you!

[justinsb]

Thanks for fixing @jcanseco

/approve /lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcanseco, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[jcanseco]

Thank you!

[atoato88]

@jcanseco LGTM :smile:

@justinsb Thank you for reviewing, justin!