search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Fix bug where Reconcile() returns nil err if status option is not nil #229

Closed jcanseco closed 2 years ago

jcanseco commented 2 years ago

What this PR does / why we need it:

This commit fixes an issue where Reconcile() can return a nil err, even if an error occured during execution, as long as the status option is not nil.

This bug effectively hid from callers of Reconcile() if an error occurred.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

This issue seems to have originated from https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/199.

k8s-ci-robot commented 2 years ago

Hi @jcanseco. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
justinsb commented 2 years ago

Thanks @jcanseco - nice fix!

/approve /lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcanseco, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atoato88 commented 2 years ago

Thank you to active contribution! LGTM (I know it has been merged already :sweat_smile: